beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2493: [BEAM-1935] Improve Work Rejection handling
Date Tue, 11 Apr 2017 18:36:13 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2493

    [BEAM-1935] Improve Work Rejection handling

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    The timing between checking for a shutdown state and submitting work is
    racy. Re-check to see if a work rejection is acceptable because the
    underlying executor is shut down before throwing a
    RejectedExecutionException.
    
    Renames to internal implementation classes of TransformExecutorServices.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam cancel_rejected_execution

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2493
    
----
commit 528830185a9735bb49a64074480760a661e39408
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-11T18:33:53Z

    Improve Work Rejection handling
    
    The timing between checking for a shutdown state and submitting work is
    racy. Re-check to see if a work rejection is acceptable because the
    underlying executor is shut down before throwing a
    RejectedExecutionException.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message