beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sb2nov <...@git.apache.org>
Subject [GitHub] beam pull request #2456: [BEAM-778] Fix the Compressed file seek tests on wi...
Date Thu, 06 Apr 2017 23:42:36 GMT
GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/2456

    [BEAM-778] Fix the Compressed file seek tests on windows

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @chamikaramj @tibkiss 
    
    The seek tests were failing on windows due to two main reasons: (1) files not being closed
before removing and (2) files not being opened as binary files. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-windows-test-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2456
    
----
commit ee225fa2c9489daa8c4b650f2a30d5d55b0a1f3d
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-04-06T23:23:33Z

    [BEAM-778] Fix the Compressed file seek tests on windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message