beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mariapython <>
Subject [GitHub] beam pull request #2443: [BEAM-802] Add ValueProvider class for FileBasedSou...
Date Wed, 05 Apr 2017 21:50:27 GMT
GitHub user mariapython opened a pull request:

    [BEAM-802] Add ValueProvider class for FileBasedSource I/O Transforms

    - [x] Add ValueProvider class.
    - [x] Derive StaticValueProvider and RuntimeValueProvider from ValueProvider.
    - [x] Derive ValueProviderArgumentParser from argparse.ArgumentParser as API for the template
    - [x] Modify FileBasedSource I/O transforms to accept objects of type ValueProvider.
    - [x] Modify display_data.
    - [x] Handle serialization / deserialization.
    Note: #2441 addresses the failure from the previous version of this PR, and the rest of
the issue is tracked in [BEAM-1889].

You can merge this pull request into a Git repository by running:

    $ git pull ppp_fix_equal

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2443
commit 57838f5be4d1854eec8a51e3aa8e583a82be38d0
Author: Maria Garcia Herrero <>
Date:   2017-04-05T21:42:13Z

    Revert "Revert "Add ValueProvider class for FileBasedSource I/O Transforms""
    This reverts commit 3eef246f761f92c626541e9008f8624b43bdcc09.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message