beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] beam pull request #2425: Rename filePath to filePattern in NumbedShardedFile
Date Tue, 04 Apr 2017 17:25:11 GMT
GitHub user kennknowles opened a pull request:

    Rename filePath to filePattern in NumbedShardedFile

    R: @reuvenlax @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull fileGlob

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2425
commit 797f4f8bc3bf69e630753f0219e220a8a9d80e2d
Author: Kenneth Knowles <>
Date:   2017-04-04T17:23:54Z

    Rename filePath to filePattern in NumbedShardedFile
    This probably would have saved a few hours of debugging by
    signposting the intended usage more clearly.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message