beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] beam pull request #2413: [BEAM-1864] Rename CombiningState and friends to be...
Date Mon, 03 Apr 2017 20:04:05 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-1864] Rename CombiningState and friends to be more user-friendly

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull combining-state

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2413
commit d723ccfce33a5ae2969e44ad20692c152c54ce78
Author: Kenneth Knowles <>
Date:   2017-04-03T18:26:30Z

    Rename CombiningState to GroupingState

commit 1aeb69d04a42d9e7d37c65f3c7db9ab33cf5dfd0
Author: Kenneth Knowles <>
Date:   2017-04-03T18:27:26Z

    Rename AccumulatorCombiningState to CombiningState

commit a272ef908dc8c123894949f85bf041b34096482b
Author: Kenneth Knowles <>
Date:   2017-04-03T18:37:50Z

    Rename combiningValue to combining in StateSpecs


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message