beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (BEAM-2123) Passing potential null pointer to encode() in StructuredCoder#structuralValue
Date Sat, 29 Apr 2017 23:29:04 GMT
Ted Yu created BEAM-2123:
----------------------------

             Summary: Passing potential null pointer to encode() in StructuredCoder#structuralValue
                 Key: BEAM-2123
                 URL: https://issues.apache.org/jira/browse/BEAM-2123
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-core
            Reporter: Ted Yu
            Assignee: Davor Bonaci
            Priority: Minor


{code}
  public Object structuralValue(T value) {
    if (value != null && consistentWithEquals()) {
      return value;
    } else {
      try {
        ByteArrayOutputStream os = new ByteArrayOutputStream();
        encode(value, os, Context.OUTER);
{code}
If value is null, encode() would throw CoderException (I checked ByteArrayCoder and KvCoder)
which would be caught and converted to IllegalArgumentException.
Looks like structuralValue() can check null value directly and throw CoderException. This
would result in clearer exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message