beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2108) Integration tests for PubsubIO
Date Fri, 28 Apr 2017 06:08:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988272#comment-15988272
] 

Daniel Halperin commented on BEAM-2108:
---------------------------------------

That would allow some deeper unit tests, however we still need some integration tests.

> Integration tests for PubsubIO
> ------------------------------
>
>                 Key: BEAM-2108
>                 URL: https://issues.apache.org/jira/browse/BEAM-2108
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-gcp, testing
>            Reporter: Eugene Kirpichov
>
> PubsubIOTest doesn't contain a single test that reads or writes a Pubsub topic. As far
as I can tell, the public Beam repo doesn't have any tests that do that, either. So, it's
really easy to break Pubsub. It's particularly easy to break because Dataflow runner has a
special implementation of Pubsub.
> We should have tests for PubsubIO (read and write; with and without attributes); running
against direct runner and against Dataflow runner (since Dataflow runner has a custom implementation
of PubsubIO)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message