beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2086) TestDataflowRunner relies on metrics which are not present in streaming jobs
Date Thu, 27 Apr 2017 01:02:04 GMT


ASF GitHub Bot commented on BEAM-2086:

GitHub user kennknowles opened a pull request:

    [BEAM-2086] Remove TestDataflowRunner reliance on metrics in streaming

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull TestDataflowRunner

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2721
commit 1008def0f28c43b8225f68a2a8f713b84b89a485
Author: Kenneth Knowles <>
Date:   2017-04-27T00:55:29Z

    Remove max watermark check from TestDataflowRunner
    The Dataflow service automatically shuts down jobs when their
    input watermarks reach infinity.

commit 35b1147d28471af1a92a938b42702dd9a0c9a98c
Author: Kenneth Knowles <>
Date:   2017-04-27T00:56:05Z

    Do not rely on PAssert metrics in streaming TestDataflowRunner
    These metrics are currently absent. This can be restored when the
    feature is returned to the Dataflow service.


> TestDataflowRunner relies on metrics which are not present in streaming jobs
> ----------------------------------------------------------------------------
>                 Key: BEAM-2086
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Blocker
> Currently, we are lacking the metrics by which the TestDataflowRunner determines that
a job is complete and that all PAsserts ran.
> We do not need to use the watermark metrics - the service handles shutdown now.
> We should aim to restore PAssert counting, though the new PAssert architecture (both
that already implemented as well as future plans) significantly mitigate the risk.

This message was sent by Atlassian JIRA

View raw message