beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2076) DirectRunner: minimal transitive API surface
Date Wed, 26 Apr 2017 21:08:04 GMT


ASF GitHub Bot commented on BEAM-2076:

GitHub user tgroh opened a pull request:

    [BEAM-2076] Shade Runner Dependencies in the DirectRunner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Move inner classes of the DirectRunner to reduce total API Surface.
    Add API Surface Test for the Direct Runner.

You can merge this pull request into a Git repository by running:

    $ git pull direct_runner_deps

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2714


> DirectRunner: minimal transitive API surface
> --------------------------------------------
>                 Key: BEAM-2076
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-direct
>            Reporter: Daniel Halperin
>            Assignee: Thomas Groh
>             Fix For: First stable release
> The {{DirectRunner}} is likely to accidentally be on many users' classpath when they
are running on other runners. As such, it should have a minimal transitive API surface, shading
things it needs directly and need not expose.
> My base assumption is that {{runners-core}} should be shaded. There may be others tho
-- this merits a bit of a look.

This message was sent by Atlassian JIRA

View raw message