beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2074) SourceDStream's rate control mechanism may not work
Date Thu, 27 Apr 2017 06:28:04 GMT


ASF GitHub Bot commented on BEAM-2074:

GitHub user staslev opened a pull request:

    [BEAM-2074,BEAM-2073] Fixed SourceDStream's rate control usage.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-2074-2073-fix-SourceDStream-rate-control

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2733
commit 609a98a96ea9cc10c87f079872975b98baf62752
Author: Stas Levin <>
Date:   2017-04-26T08:46:31Z

    Fixed SourceDStream's rate control usage.


> SourceDStream's rate control mechanism may not work
> ---------------------------------------------------
>                 Key: BEAM-2074
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Stas Levin
>            Assignee: Stas Levin
> If the {{boundMaxRecords}} for {{SourceDStream}} is not set (as a result of users choosing
not to specify {{SparkPipelineOptions.setMaxRecordsPerBatch()}}), {{SourceDStream}} is designed
to use {{rateControlledMaxRecords()}} to determine the max number of records it should be
> However, at the moment {{SourceDStream}} only consults  {{rateControlledMaxRecords()}}
once, when it is created, thus following
> instantiations of {{MicrobatchSource}} will be using the now-set-in-stone {{boundMaxRecords}}
value without consulting with {{rateControlledMaxRecords()}}, making the rate controlling
mechanism sub-optimal.

This message was sent by Atlassian JIRA

View raw message