beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Sisk (JIRA)" <>
Subject [jira] [Updated] (BEAM-2069) Remove ResourceId.getCurrentDirectory()?
Date Mon, 24 Apr 2017 23:37:04 GMT


Stephen Sisk updated BEAM-2069:
    Summary: Remove ResourceId.getCurrentDirectory()?  (was: Remove FileSystem.getCurrentDirectory()?)

> Remove ResourceId.getCurrentDirectory()?
> ----------------------------------------
>                 Key: BEAM-2069
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: First stable release
>            Reporter: Stephen Sisk
>            Assignee: Davor Bonaci
>              Labels: backward-incompatible
> Beam FileSystem currently has a getCurrentDirectory method that returns the current resource
id if it's a directory, or the parent directory if it's a directory.
> To implement this you need to know whether or not a particular path is a directory or
> I'm trying to implement the Hadoop FileSystem implementation, and it's not clear if it's
possible. Hadoop's Paths do not end a / if they are a directory (they are stripped), nor do
hadoop paths tell you if something is a directory, so it's not possible to determine if a
given path is a file that does not have a suffix, or a directory.
> It's not clear to me that all file systems can determine whether a path is a directory
and thus I don't believe it can be implemented reliably.
> The only usages of getCurrentDirectory that I could find are in tests so it's not clear
we actually need this.
> I propose that we remove this method.
> cc [~davor]

This message was sent by Atlassian JIRA

View raw message