beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2022) ApexTimerInternals seems to treat processing time timers as event time timers
Date Sat, 29 Apr 2017 15:45:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989919#comment-15989919
] 

ASF GitHub Bot commented on BEAM-2022:
--------------------------------------

GitHub user tweise opened a pull request:

    https://github.com/apache/beam/pull/2782

    [BEAM-2022] fix triggering for processing time timers

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    R: @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tweise/beam BEAM-2022-processingTimeTimers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2782
    
----
commit eb860388a8626837655e82171c8480421384e419
Author: Thomas Weise <thw@apache.org>
Date:   2017-04-29T08:17:22Z

    BEAM-2022 fix triggering for processing time timers

----


> ApexTimerInternals seems to treat processing time timers as event time timers
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-2022
>                 URL: https://issues.apache.org/jira/browse/BEAM-2022
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-apex
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Weise
>             Fix For: First stable release
>
>
> I first noticed that {{currentProcessingTime()}} was using {{Instant.now()}}, which has
some bad issues in a distributed setting. But it seemed on inspection that processing time
timers are simply treated as event time. Perhaps I am reading the code wrong?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message