beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
Date Mon, 24 Apr 2017 21:59:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981981#comment-15981981
] 

ASF GitHub Bot commented on BEAM-1988:
--------------------------------------

GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/2665

    [BEAM-1988] Add FileSystems Interface for accessing underlying FS

    …rectly
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @chamikaramj @aaltay PTAL

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-1988-filesystems-interface

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2665.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2665
    
----
commit ec3b30feb58914aec03ef5d1d10e373c96dc7b4e
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-04-24T21:57:09Z

    [BEAM-1988] Add FileSystems Interface for accessing underlying FS correctly

----


> utils.path.join does not correctly handle GCS bucket roots
> ----------------------------------------------------------
>
>                 Key: BEAM-1988
>                 URL: https://issues.apache.org/jira/browse/BEAM-1988
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Assignee: Sourabh Bajaj
>             Fix For: First stable release
>
>
> Here:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results in invalid
'gs://mybucket//myfile', notice the double // between mybucket and myfile. (It actually does
not handle anything that already ends with {{/}} correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to a BeamFileSystem
level code.
> (cc: [~chamikara])



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message