beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
Date Tue, 18 Apr 2017 23:19:41 GMT


ASF GitHub Bot commented on BEAM-1988:

GitHub user sb2nov opened a pull request:

    [BEAM-1988] Add join operation to the filesystem

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @chamikaramj PTAL

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-1988-path-join-filesystem

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2585
commit 882ec31503aff88614b368e65da7b5ed67488fb7
Author: Sourabh Bajaj <>
Date:   2017-04-18T23:18:38Z

    [BEAM-1988] Add join operation to the filesystem


> utils.path.join does not correctly handle GCS bucket roots
> ----------------------------------------------------------
>                 Key: BEAM-1988
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Assignee: Sourabh Bajaj
> Here:
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results in invalid
'gs://mybucket//myfile', notice the double // between mybucket and myfile. (It actually does
not handle anything that already ends with {{/}} correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to a BeamFileSystem
level code.
> (cc: [~chamikara])

This message was sent by Atlassian JIRA

View raw message