beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
Date Sun, 23 Apr 2017 19:56:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980517#comment-15980517
] 

ASF GitHub Bot commented on BEAM-1988:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2643


> utils.path.join does not correctly handle GCS bucket roots
> ----------------------------------------------------------
>
>                 Key: BEAM-1988
>                 URL: https://issues.apache.org/jira/browse/BEAM-1988
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Assignee: Sourabh Bajaj
>             Fix For: First stable release
>
>
> Here:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results in invalid
'gs://mybucket//myfile', notice the double // between mybucket and myfile. (It actually does
not handle anything that already ends with {{/}} correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to a BeamFileSystem
level code.
> (cc: [~chamikara])



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message