beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1949) Rename DoFn.Context#sideOutput to #output
Date Tue, 18 Apr 2017 19:01:43 GMT


ASF GitHub Bot commented on BEAM-1949:

GitHub user melap opened a pull request:

    [BEAM-1949] Doc changes for Python SideOutputValue to OutputValue rename

    Doc changes associated with apache/beam#2562
    note that the code snippets won't show up on the staging page until the main PR is merged
    R: @tgroh @aaltay 

You can merge this pull request into a Git repository by running:

    $ git pull pythonsideoutputs

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #214
commit ff779cf07cf621d4ee92c3c406bee81609e8365a
Author: melissa <>
Date:   2017-04-18T18:36:42Z

    [BEAM-1949] Doc changes for Python SideOutputValue to OutputValue rename


> Rename DoFn.Context#sideOutput to #output
> -----------------------------------------
>                 Key: BEAM-1949
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
> Having two methods, both named output, one which takes the "main output type" and one
that takes a tag to specify the type more clearly communicates the actual behavior - sideOutput
isn't a "special" way to output, it's the same as output(T), just to a specified PCollection.
This will help pipeline authors understand the actual behavior of outputting to a tag, and
detangle it from "sideInput", which is a special way to receive input. Giving them the same
name means that it's not even strange to call output and provide the main output type, which
is what we want - it's a more specific way to output, but does not have different restrictions
or capabilities.
> This is also a pretty small change within the SDK - it touches about 20 files, and the
changes are pretty automatic.

This message was sent by Atlassian JIRA

View raw message