beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1937) PipelineSurgery renumbers already-unique transforms
Date Wed, 12 Apr 2017 01:18:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965231#comment-15965231
] 

ASF GitHub Bot commented on BEAM-1937:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2506

    [BEAM-1937] Free PTransform Names if they are being Replaced

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Naming is based on what's in the graph, not what once was there.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam replacement_names_freed

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2506
    
----
commit 9fbe5e384ee0b64ceb87a6851ae985802f8e5eb4
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-12T01:17:02Z

    Free PTransform Names if they are being Replaced
    
    Naming is based on what's in the graph, not what once was there.

----


> PipelineSurgery renumbers already-unique transforms
> ---------------------------------------------------
>
>                 Key: BEAM-1937
>                 URL: https://issues.apache.org/jira/browse/BEAM-1937
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Thomas Groh
>         Attachments: wordcount renumbered.png
>
>
> In the attached WordCount graph, it appears that some transforms have a 2 at the end
after submission. However, I'm pretty confident that there only 1 finalize and only 1 WriteBundles
in this graph.
> [~tgroh] believes this is a bug in pipeline surgery.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message