beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1922) DataSource in JdbcIO is not closed
Date Mon, 10 Apr 2017 18:25:41 GMT


ASF GitHub Bot commented on BEAM-1922:

GitHub user XuMingmin opened a pull request:

    [BEAM-1922] DataSource in JdbcIO is not closed

    add `close()` for `BasicDataSource`. When user call with `DataSourceConfiguration.create(dataSource)`,
it's not available as no `close()` method is there.

You can merge this pull request into a Git repository by running:

    $ git pull BEAM1922

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2482
commit b0bce28b90743336233be89b645c4f8028b36538
Author: mingmxu <>
Date:   2017-04-10T18:19:02Z

    add close() for BasicDataSource


> DataSource in JdbcIO is not closed
> ----------------------------------
>                 Key: BEAM-1922
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
> The line below is not closed properly, 
> {code}
> BasicDataSource basicDataSource = new BasicDataSource();
> {code}
> It's a potential issue for the other usage, although {{DataSource}} doesn't have a {{close()}}
> {code}
> public static DataSourceConfiguration create(DataSource dataSource)
> {code}

This message was sent by Atlassian JIRA

View raw message