beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1914) XML IO should comply with PTransform style guide
Date Tue, 18 Apr 2017 00:15:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971875#comment-15971875
] 

ASF GitHub Bot commented on BEAM-1914:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/2558

    [BEAM-1914] XmlIO should comply with PTransform style guide

    R: @jbonofre 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam xml-style

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2558
    
----
commit 5b390644dfc3f7c9ebbf68b49d9f1966b4ee06e1
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-17T23:25:42Z

    Ignore AutoValue generated classes in DisplayData

commit 8cebc0334c1818790b4052c83d390d8080d1cfdc
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-17T23:25:59Z

    [BEAM-1914] Converts XmlSource to XmlIO.read()

commit 71ecb4ddfcf612bb6edad33defa4c034b6b38c61
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-17T23:31:21Z

    Gets rid of XmlSink.Bound

commit 91e58ed186864a6fa026552e0f30bd8d64bf0333
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-17T23:50:16Z

    Converts XmlSink to XmlIO.write()

----


> XML IO should comply with PTransform style guide
> ------------------------------------------------
>
>                 Key: BEAM-1914
>                 URL: https://issues.apache.org/jira/browse/BEAM-1914
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>              Labels: backward-incompatible, starter
>
> Currently we have XmlSource and XmlSink in the Java SDK. They violate the PTransform
style guide in several respects:
> - They should be grouped into an XmlIO class with read() and write() verbs, like all
the other similar connectors
> - The source/sink classes should be made private or package-local
> - Should get rid of XmlSink.Bound - XmlSink itself should inherit from FileBasedSink
> - Could optionally benefit from AutoValue
> See e.g. the PR with BigQuery fixes https://github.com/apache/beam/pull/2149



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message