beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1913) TFRecordIO should comply with PTransform style guide
Date Tue, 18 Apr 2017 00:53:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971911#comment-15971911
] 

ASF GitHub Bot commented on BEAM-1913:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/2559

    [BEAM-1913] TFRecordIO should comply with PTransform style guide

    https://issues.apache.org/jira/browse/BEAM-1913
    
    R: @aviemzur 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam tf-style

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2559.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2559
    
----
commit 91f8b632731ba638940281fafb63a685f46e74a3
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-18T00:21:34Z

    Gets rid of TFRecordIO.Read.Bound

commit 1d695f04b9b1386154dc5b9844ca110693ed1d83
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-18T00:29:06Z

    Converts TFRecordIO.Read to AutoValue

commit 5b43df9e12db8a467e60b76ab92c53f0ed3e7a5c
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-18T00:38:08Z

    Gets rid of TFRecordIO.Write.Bound

commit 7d89bb4661907a3e129c78d29fb8f7e68db12a24
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-18T00:50:24Z

    Converts TFRecordIO.Write to AutoValue

----


> TFRecordIO should comply with PTransform style guide
> ----------------------------------------------------
>
>                 Key: BEAM-1913
>                 URL: https://issues.apache.org/jira/browse/BEAM-1913
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>              Labels: backward-incompatible, starter
>
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java
violates a few guidelines from https://beam.apache.org/contribute/ptransform-style-guide/
:
> - Use of Bound and Unbound types: the Read and Write classes themselves should be PTransform's
> - Should have one static entry point per verb - read() and write()
> - Both classes could benefit from AutoValue
> Basically, perform similar surgery like in https://github.com/apache/beam/pull/2149 but
on smaller scale since this is a much smaller connector.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message