beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (BEAM-1907) Delete PubsubBoundedReader
Date Tue, 11 Apr 2017 12:15:41 GMT

     [ https://issues.apache.org/jira/browse/BEAM-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Daniel Halperin resolved BEAM-1907.
-----------------------------------
    Resolution: Fixed

> Delete PubsubBoundedReader
> --------------------------
>
>                 Key: BEAM-1907
>                 URL: https://issues.apache.org/jira/browse/BEAM-1907
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-gcp
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>             Fix For: First stable release
>
>
> PubsubIO in bounded mode doesn't really make sense, outside of hacky testing modes --
it might lose data, other stuff that's sketchy. We had it before because the old {{DirectRunner}}
did not support unbounded PCollections. Now that it does, we should probably get rid of this
buggy code.
> Specifically:
> * Delete the specialized PubsubBoundedReader implementation
> * Either: delete the maxNumRecords and maxReadTime methods, or rename them to something
like maxNumRecordsForTesting with clear javadoc as to their drawbacks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message