beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ismaël Mejía (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-1881) Exclude protobuf-lite everywhere
Date Wed, 05 Apr 2017 04:44:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956287#comment-15956287
] 

Ismaël Mejía edited comment on BEAM-1881 at 4/5/17 4:43 AM:
------------------------------------------------------------

Great to know, I used this dependency without been sure. It deserves even a cross-project
PR to make this clearer in the protobuf documentation, I looked at it and I was not sure of
which version should one use and some people on stack overflow just said take the lite and
if it is not enough move to the full one, but I could not confirm this so I followed the version
other dependencies were using. Worth fix.
Another unintended fix of this one is to get rid of the version issue, protobuf-lite is pinned
to version 3.0.1, while protobuf-java to 3.1.0 in the parent pom.


was (Author: iemejia):
Great to know, I used this dependency without been sure. It deserves even a cross-project
PR to make this clearer in the protobuf documentation, I looked at it and I was not sure of
which version should one use and some people on stack overflow just said take the lite and
if it is not enough move to the full one, but I could not confirm this so I followed the version
other dependencies were using. Worth fix.

> Exclude protobuf-lite everywhere
> --------------------------------
>
>                 Key: BEAM-1881
>                 URL: https://issues.apache.org/jira/browse/BEAM-1881
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>             Fix For: First stable release
>
>
> Protobuf-lite and protobuf-java are completely incompatible. Apparently, protobuf-lite
is not "lite", it should really be used only in Android.
> So we should be very careful to exclude -lite everywhere and enforce java.
> And if possible, use an enforcer to prevent any dependencies on -lite ever.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message