beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1869) getProducingTransformInternal should not be available on any PValue
Date Mon, 03 Apr 2017 23:29:41 GMT


ASF GitHub Bot commented on BEAM-1869:

GitHub user tgroh opened a pull request:

    [BEAM-1869] Remove GetProducingTransformInternal

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This isn't part of the PValue API, so remove from POutputValueBase.

You can merge this pull request into a Git repository by running:

    $ git pull remove_get_producing_transform_internal

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2416
commit 09d8c76b1111b847d354363828efdc1f5f2958e9
Author: Thomas Groh <>
Date:   2017-04-03T23:26:10Z

    Remove GetProducingTransformInternal
    This isn't part of the API surface, and is no longer part of


> getProducingTransformInternal should not be available on any PValue
> -------------------------------------------------------------------
>                 Key: BEAM-1869
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
> This method is not guaranteed to return the correct value, as the TransformHierarchy
can be updated without calling back into this method.
> It also is not a responsibility of POutput/POutputValueBase, but is a responsibility
of the Transform Hierarchy.

This message was sent by Atlassian JIRA

View raw message