beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1786) AutoService registration of coders, like we do with PipelineRunners
Date Fri, 21 Apr 2017 21:21:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979398#comment-15979398
] 

ASF GitHub Bot commented on BEAM-1786:
--------------------------------------

GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/2637

    [BEAM-1786] Post Dataflow worker CoderRegistry clean-up

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam thin_sdk_core

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2637
    
----
commit 1b8678136a420e360e23e6ff5deac5f368a7a43c
Author: Luke Cwik <lcwik@google.com>
Date:   2017-04-21T21:04:51Z

    [BEAM-1786] Post Dataflow worker CoderRegistry clean-up

----


> AutoService registration of coders, like we do with PipelineRunners
> -------------------------------------------------------------------
>
>                 Key: BEAM-1786
>                 URL: https://issues.apache.org/jira/browse/BEAM-1786
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Luke Cwik
>             Fix For: First stable release
>
>
> Today, registering coders for auxiliary data types for a library transform is not very
convenient. It the appears in an output/covariant position then it might be possible to use
{{getDefaultOutputCoder}} to solve things. But for writes/contravariant positions this is
not applicable and the library transform must contort itself to avoid requiring the user to
come up with a coder for a type they don't own.
> Probably the best case today is an explicit call to {{LibraryTransform.registerCoders(Pipeline)}}
which is far too manual.
> This could likely be solved quite easily with {{@AutoService}} and a static global coder
registry, as we do with pipeline runners.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message