beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1579) Runners should verify that PT overrides converged
Date Tue, 04 Apr 2017 17:22:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955454#comment-15955454
] 

ASF GitHub Bot commented on BEAM-1579:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2424

    [BEAM-1579] Remove single-matcher replacement API

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This makes it more difficult for runner authors to use the discouraged
    API that doesn't validate ordering of replacements.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam remove_replace_single

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2424
    
----
commit 47c0a09a6621811ee8fd8208eb7c0f8be2854746
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-04T17:20:49Z

    Remove single-matcher replacement API
    
    This makes it more difficult for runner authors to use the discouraged
    API that doesn't validate ordering of replacements.

----


> Runners should verify that PT overrides converged
> -------------------------------------------------
>
>                 Key: BEAM-1579
>                 URL: https://issues.apache.org/jira/browse/BEAM-1579
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core, runner-dataflow, runner-direct
>            Reporter: Eugene Kirpichov
>            Assignee: Thomas Groh
>
> PT overrides are applied in order, see https://issues.apache.org/jira/browse/BEAM-1578
.
> To make sure that the order is correct and avoid confusing errors, after applying the
overrides in order, we should verify that the pipeline has converged, i.e. the overrides no
longer match.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message