beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1508) PInput, POutput#expand should not be ordered
Date Tue, 04 Apr 2017 23:55:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956075#comment-15956075
] 

ASF GitHub Bot commented on BEAM-1508:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2430

    [BEAM-1508] Remove Orderdness of Input, Output expansions

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This brings the PInput and POutput expansion signatures back in line
    with the Runner API.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam transform_hierarchy_additional_inputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2430
    
----
commit d91d7aacbd64f5081526ceec10685f8530994190
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-04T23:51:55Z

    Remove Orderdness of Input, Output expansions
    
    This brings the PInput and POutput expansion signatures back in line
    with the Runner API.

----


> PInput, POutput#expand should not be ordered
> --------------------------------------------
>
>                 Key: BEAM-1508
>                 URL: https://issues.apache.org/jira/browse/BEAM-1508
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model-runner-api, sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> Ordering should be a local concern to how the PTransform is defined; the outputs should
have meaning independent of the order in which they are enumerated.
> This also simplifies some implementation on the Runner-API side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message