beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Kirpichov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1355) HDFS IO should comply with PTransform style guide
Date Tue, 18 Apr 2017 21:59:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973593#comment-15973593
] 

Eugene Kirpichov commented on BEAM-1355:
----------------------------------------

Stephen - do you think then, perhaps, that we should delete HDFSFileSource/Sink for the first
stable release, as soon as BEAM-2005 is done?

> HDFS IO should comply with PTransform style guide
> -------------------------------------------------
>
>                 Key: BEAM-1355
>                 URL: https://issues.apache.org/jira/browse/BEAM-1355
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Eugene Kirpichov
>            Assignee: Stephen Sisk
>              Labels: backward-incompatible
>
> https://github.com/apache/beam/tree/master/sdks/java/io/hdfs/src/main/java/org/apache/beam/sdk/io/hdfs
does not comply with https://beam.apache.org/contribute/ptransform-style-guide/ in a number
of ways:
> - It is not packaged as a PTransform (should be: HDFSIO.Read,Write or something like
that)
> - Should probably use AutoValue for specifying parameters
> Stephen knows about the current state of HDFS IO.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message