beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1353) Beam should comply with PTransform style guide
Date Thu, 20 Apr 2017 19:37:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977330#comment-15977330
] 

ASF GitHub Bot commented on BEAM-1353:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2615

    Use the Input Coder in Dataflow Pubsub Write

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    If no element coder is specified, and one is required, use the element
    coder of the input PCollection as the encoding input. The coder is known
    to have the appropriate type.
    
    R: @reuvenlax 
    
    This is likely going away as part of https://issues.apache.org/jira/browse/BEAM-1353;
    we should require a `T -> bytes` conversion to be explicitly specified rather than
using a Coder.
    Right now the input coder is not always defined. This fixes that bug.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam pubsub_write_coder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2615.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2615
    
----
commit 4dd597621a9fce3fc95d6a265d4c9eaf70648326
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-20T19:29:24Z

    Use the Input Coder in Dataflow Pubsub Write
    
    If no element coder is specified, and one is required, use the element
    coder of the input PCollection as the encoding input. The coder is known
    to have the appropriate type.

----


> Beam should comply with PTransform style guide
> ----------------------------------------------
>
>                 Key: BEAM-1353
>                 URL: https://issues.apache.org/jira/browse/BEAM-1353
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core, sdk-java-extensions, sdk-java-gcp, sdk-py
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>              Labels: backward-incompatible, easy, starter
>             Fix For: First stable release
>
>
> https://beam.apache.org/contribute/ptransform-style-guide/ is a collection of best practices
for developing PTransform's.
> Some of these practices shaped up relatively recently, and some Beam transforms violate
them, introducing inconsistency into Beam APIs and tempting new library writers and users
into mimicking code that's best not mimicked.
> This is an umbrella bug for cleanups bringing individual Beam transforms in accordance
with the style guide.
> Please file 1 bug per transform that needs to be fixed (e.g. "Bring KafkaIO in accordance
with style guide"); in the bug, describe which aspects need to be fixed (e.g. "should use
AutoValue; should explicitly specify type parameters; should not use Coders for serialization")
and link it with the current bug.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message