beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1327) Replace OutputTimeFn with enum
Date Tue, 25 Apr 2017 21:48:04 GMT


ASF GitHub Bot commented on BEAM-1327:

GitHub user kennknowles opened a pull request:

    [BEAM-1327] Replace OutputTimeFn UDF with TimestampCombiner enum

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull deprecate-OutputTimeFn

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2683
commit 1bcb8333e16102ad57a4524e0dea52aa6d4c92c2
Author: Kenneth Knowles <>
Date:   2017-01-27T03:56:06Z

    Replace OutputTimeFn UDF with TimestampCombiner enum


> Replace OutputTimeFn with enum
> ------------------------------
>                 Key: BEAM-1327
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Minor
>              Labels: backward-incompatible
>             Fix For: First stable release
> The class {{OutputTimeFn}} is overkill for a Fn API crossing. There are only three sensible
values known: MIN, MAX, EOW. The interface is right for implementing these, but the full class
is left over from the days when there was little cost to shipping new kinds of fns. An enum
is concise.
> This can be done "mostly" backwards compatibly with legacy adapters in place, but might
be less confusing without them.

This message was sent by Atlassian JIRA

View raw message