beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1316) DoFn#startBundle should not be able to output
Date Wed, 26 Apr 2017 01:22:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983961#comment-15983961
] 

ASF GitHub Bot commented on BEAM-1316:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2695

    [BEAM-1316] Forbid output in StartBundle

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    TODO: Add comments, audit any other context creation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam no_start_bundle_output

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2695
    
----
commit 5d369da267405911e534e49ad74fdb64bc2c3150
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-26T01:20:21Z

    Forbid output in StartBundle

----


> DoFn#startBundle should not be able to output
> ---------------------------------------------
>
>                 Key: BEAM-1316
>                 URL: https://issues.apache.org/jira/browse/BEAM-1316
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>             Fix For: First stable release
>
>
> While within startBundle and finishBundle, the window in which elements are output is
not generally defined. Elements must always be output from within a windowed context, or the
{{WindowFn}} used by the {{PCollection}} may not operate appropriately.
> startBundle and finishBundle are suitable for operational duties, similarly to {{setup}}
and {{teardown}}, but within the scope of some collection of input elements. This includes
actions such as clearing field state within a DoFn and ensuring all live RPCs complete successfully
before committing inputs.
> Sometimes it might be reasonable to output from {{@FinishBundle}} but it is hard to imagine
a situation where output from {{@StartBundle}} is useful in a way that doesn't seriously abuse
things.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message