beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1198) ViewFn: explicitly decouple runner materialization of side inputs from SDK-specific mapping
Date Wed, 05 Apr 2017 21:01:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957664#comment-15957664
] 

ASF GitHub Bot commented on BEAM-1198:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2440

    [BEAM-1198] Add Initial Materializations

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam view_fn_materialization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2440
    
----
commit ed0c629173e9ec35e930f95ab15627c120d5d667
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-03T23:25:08Z

    Add Initial Materializations

----


> ViewFn: explicitly decouple runner materialization of side inputs from SDK-specific mapping
> -------------------------------------------------------------------------------------------
>
>                 Key: BEAM-1198
>                 URL: https://issues.apache.org/jira/browse/BEAM-1198
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model-fn-api, beam-model-runner-api
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>             Fix For: Not applicable, First stable release
>
>
> For side inputs, the field {{PCollectionView.fromIterableInternal}} implies an "iterable"
materialization of the contents of a PCollection, which is adapted to the desired user-facing
type within a UDF (today the PCollectionView "is" the UDF)
> In practice, runners get adequate performance by special casing just a couple of types
of PCollectionView in a rather cumbersome manner.
> The design to improve this is https://s.apache.org/beam-side-inputs-1-pager and this
makes the de facto standard approach the actual model.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message