beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmet Altay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1179) Update assertions of source_test_utils from camelcase to underscore-separated
Date Thu, 06 Apr 2017 17:08:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959318#comment-15959318
] 

Ahmet Altay commented on BEAM-1179:
-----------------------------------

Updated link: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/source_test_utils.py

[~chamikara] Any progress on this?

> Update assertions of source_test_utils from camelcase to underscore-separated
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-1179
>                 URL: https://issues.apache.org/jira/browse/BEAM-1179
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>             Fix For: First stable release
>
>
> Assertions in source_test_utils module [1] currently have method names in camel case.
This was original done so that it's similar to assertions in Python unittest module. But it's
better to deprecate these and add underscore-separated variations so that code in Python SDK
is consistent.
> [1] https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/io/source_test_utils.py



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message