beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1166) Source.getDefaultOutputCoder() documentation should mention CannotProvideCoderException
Date Thu, 13 Apr 2017 00:29:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966922#comment-15966922
] 

ASF GitHub Bot commented on BEAM-1166:
--------------------------------------

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/2520

    [BEAM-1166] Update docs for getDefaultOutputCoder

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    I may not have the docs entirely correct - let me know if there's a better way to phrase
this.
    
    R @jkff 
    cc @dhalperi 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam source-docs-fixup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2520
    
----
commit 2241474191117910e4d285d027291ef6b5a2759b
Author: Stephen Sisk <sisk@google.com>
Date:   2017-04-13T00:26:48Z

    Update docs for getDefaultOutputCoder

----


> Source.getDefaultOutputCoder() documentation should mention CannotProvideCoderException
> ---------------------------------------------------------------------------------------
>
>                 Key: BEAM-1166
>                 URL: https://issues.apache.org/jira/browse/BEAM-1166
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Stephen Sisk
>            Assignee: Stephen Sisk
>
> Knowing that you can throw CannotProviderCoderException is an important part of implementing
getDefaultOutputCoder
> The documentation for PTransform's getDefaultOutputCoder mentions this class, and we
should do this for the Source class as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message