beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-846) Decouple side input window mapping from WindowFn
Date Wed, 05 Apr 2017 18:54:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957435#comment-15957435
] 

ASF GitHub Bot commented on BEAM-846:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2436

    [BEAM-846] Use getWindowMappingFn where possible

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Migrates callers away from the user of WindowingStrategyInternal,
    permitting future changes to have a configurable WindowMappingFn.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam remove_view_windowing_strategy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2436
    
----
commit 8dbc8ba62091762272dfa66fade841288c7fff6c
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-05T18:53:03Z

    Use WinodwMappingFn where possible
    
    Migrates callers away from the user of WindowingStrategyInternal,
    permitting future changes to have a configurable WindowMappingFn.

----


> Decouple side input window mapping from WindowFn
> ------------------------------------------------
>
>                 Key: BEAM-846
>                 URL: https://issues.apache.org/jira/browse/BEAM-846
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model-runner-api, sdk-java-core
>            Reporter: Robert Bradshaw
>            Assignee: Thomas Groh
>              Labels: backward-incompatible
>             Fix For: First stable release
>
>
> Currently the main WindowFn provides as getSideInputWindow method. Instead, this mapping
should be specified per-side-input (thought the default mapping would remain the same). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message