beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-846) Decouple side input window mapping from WindowFn
Date Wed, 05 Apr 2017 16:26:41 GMT


ASF GitHub Bot commented on BEAM-846:

GitHub user tgroh opened a pull request:

    [BEAM-846] Add WindowMappingFn to PCollectionView

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This exposes the explicit way in which Windows should be mapped.

You can merge this pull request into a Git repository by running:

    $ git pull expose_window_mapping_fn

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2434


> Decouple side input window mapping from WindowFn
> ------------------------------------------------
>                 Key: BEAM-846
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model-runner-api, sdk-java-core
>            Reporter: Robert Bradshaw
>            Assignee: Thomas Groh
>              Labels: backward-incompatible
>             Fix For: First stable release
> Currently the main WindowFn provides as getSideInputWindow method. Instead, this mapping
should be specified per-side-input (thought the default mapping would remain the same). 

This message was sent by Atlassian JIRA

View raw message