beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-818) Remove Pipeline.getPipelineOptions
Date Mon, 24 Apr 2017 22:27:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982018#comment-15982018
] 

ASF GitHub Bot commented on BEAM-818:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2666

    [BEAM-818,BEAM-827,BEAM-828] Remove some construction-time uses of PipelineOptions

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam PipelineOptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2666
    
----
commit a94c216ccbd2b2dd19617f2a6410d2200d15d828
Author: Kenneth Knowles <klk@google.com>
Date:   2017-04-24T19:49:39Z

    Move stable name validation to Pipeline.run()
    
    The action taken when a pipeline does not have unique stable
    names depends on the PipelineOptions, which will not available
    during construction. Moving this later removes one blocker
    from the refactor to PipelineOptions availability.

commit 93755eb3722eadd1bce5d99aaee4625d632f3625
Author: Kenneth Knowles <klk@google.com>
Date:   2017-04-24T20:57:23Z

    Remove PipelineOptions from createWriteOperation()

commit f28f3e67776d7203d3635b7d0732bd5adf83366f
Author: Kenneth Knowles <klk@google.com>
Date:   2017-04-24T21:37:30Z

    Move PTransform.validate to post-construction

commit 7d575eea183863441a7f8646efdd8876fa0cdc3d
Author: Kenneth Knowles <klk@google.com>
Date:   2017-04-24T19:50:57Z

    Supply PipelineOptions at Pipeline.run()

----


> Remove Pipeline.getPipelineOptions
> ----------------------------------
>
>                 Key: BEAM-818
>                 URL: https://issues.apache.org/jira/browse/BEAM-818
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible
>             Fix For: First stable release
>
>
> This stops transforms from changing their operation based on construction-time options,
and instead requires that configuration to be explicit, or to obtain the configuration at
runtime.
> https://docs.google.com/document/d/1Wr05cYdqnCfrLLqSk--XmGMGgDwwNwWZaFbxLKvPqEQ/edit#



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message