beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-778) Make filesystem._CompressedFile seekable.
Date Thu, 06 Apr 2017 23:42:41 GMT


ASF GitHub Bot commented on BEAM-778:

GitHub user sb2nov opened a pull request:

    [BEAM-778] Fix the Compressed file seek tests on windows

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @chamikaramj @tibkiss 
    The seek tests were failing on windows due to two main reasons: (1) files not being closed
before removing and (2) files not being opened as binary files. 

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-windows-test-fix

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2456
commit ee225fa2c9489daa8c4b650f2a30d5d55b0a1f3d
Author: Sourabh Bajaj <>
Date:   2017-04-06T23:23:33Z

    [BEAM-778] Fix the Compressed file seek tests on windows


> Make filesystem._CompressedFile seekable.
> -----------------------------------------
>                 Key: BEAM-778
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Tibor Kiss
>             Fix For: Not applicable
> We have a TODO to make filesystem._CompressedFile seekable.
> Without this, compressed file objects produce for FileBasedSource implementations may
not be able to use libraries that utilize methods seek() and tell().
> For example

This message was sent by Atlassian JIRA

View raw message