beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lc...@apache.org
Subject [1/2] beam git commit: Remove redundant private on enum constructors
Date Sun, 30 Apr 2017 04:55:46 GMT
Repository: beam
Updated Branches:
  refs/heads/master e52228166 -> 33358eb23


Remove redundant private on enum constructors

https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#jls-8.9.2


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/f5304b1b
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/f5304b1b
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/f5304b1b

Branch: refs/heads/master
Commit: f5304b1b1599b5d373fc0db01f51711a524ec45b
Parents: e522281
Author: wtanaka.com <wtanaka@yahoo.com>
Authored: Sat Apr 29 18:27:43 2017 -1000
Committer: Lukasz Cwik <lcwik@google.com>
Committed: Sat Apr 29 21:55:05 2017 -0700

----------------------------------------------------------------------
 .../core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java   | 2 +-
 .../java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java    | 2 +-
 .../src/main/java/org/apache/beam/sdk/util/CloudKnownType.java     | 2 +-
 .../org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/f5304b1b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
index 3354c67..253a08b 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
@@ -195,7 +195,7 @@ public abstract class FileBasedSink<T> implements Serializable,
HasDisplayData {
     private String filenameSuffix;
     private String mimeType;
 
-    private CompressionType(String suffix, String mimeType) {
+    CompressionType(String suffix, String mimeType) {
       this.filenameSuffix = suffix;
       this.mimeType = mimeType;
     }

http://git-wip-us.apache.org/repos/asf/beam/blob/f5304b1b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
index 158bb04..b43c7a3 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
@@ -317,7 +317,7 @@ public final class PaneInfo {
 
       public final byte tag;
 
-      private Encoding() {
+      Encoding() {
         assert ordinal() < 16;
         tag = (byte) (ordinal() << 4);
       }

http://git-wip-us.apache.org/repos/asf/beam/blob/f5304b1b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java
index b22b3c0..430319b 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java
@@ -84,7 +84,7 @@ enum CloudKnownType {
   private final String uri;
   private final Class<?>[] classes;
 
-  private CloudKnownType(String uri, Class<?>... classes) {
+  CloudKnownType(String uri, Class<?>... classes) {
     this.uri = uri;
     this.classes = classes;
   }

http://git-wip-us.apache.org/repos/asf/beam/blob/f5304b1b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
index 4e257f1..323c24c 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java
@@ -154,7 +154,7 @@ public class ProxyInvocationHandlerTest {
     MyEnum("MyTestEnum");
 
     private final String value;
-    private EnumType(String value) {
+    EnumType(String value) {
       this.value = value;
     }
 


Mime
View raw message