beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <>
Subject [GitHub] beam pull request #2633: Make it possible to test runners that don't support...
Date Mon, 24 Apr 2017 21:07:48 GMT
GitHub user dhalperi reopened a pull request:

    Make it possible to test runners that don't support all metrics

    Runners may only partially support metrics. This partial support runs along axes:
    - attempted & committed
    - counters & distributions & gauges & ...
    Prior to this PR, we have categories for the first axis, but not the second.
    This means that a runner that supports only part of the second axis has to blacklist tests
    on the first axis. Adding categories for both axes lets runners build a matrix of supported
    I also renamed the existing categories so that they are grouped alphabetically. Happy
    undo if this is not a good change.
    This also lets the DataflowRunner run more tests by accurately identifying its test

You can merge this pull request into a Git repository by running:

    $ git pull metrics-tests

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2633


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message