Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EAB04200C28 for ; Mon, 13 Mar 2017 15:58:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E6781160B6C; Mon, 13 Mar 2017 14:58:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3B437160B60 for ; Mon, 13 Mar 2017 15:58:32 +0100 (CET) Received: (qmail 4331 invoked by uid 500); 13 Mar 2017 14:58:31 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 4314 invoked by uid 99); 13 Mar 2017 14:58:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 14:58:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 22741DFE20; Mon, 13 Mar 2017 14:58:30 +0000 (UTC) From: iemejia To: commits@beam.apache.org Reply-To: commits@beam.apache.org Message-ID: Subject: [GitHub] beam pull request #2231: [BEAM-923] Add localhost option for DatastoreIO (fi... Content-Type: text/plain Date: Mon, 13 Mar 2017 14:58:30 +0000 (UTC) archived-at: Mon, 13 Mar 2017 14:58:33 -0000 GitHub user iemejia opened a pull request: https://github.com/apache/beam/pull/2231 [BEAM-923] Add localhost option for DatastoreIO (fix assignment issue) Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/iemejia/beam BEAM-923-localhost-for-datastore Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2231.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2231 ---- commit eb7b5dd6c218f19f000119baf4ff330dac970748 Author: Ismaël Mejía Date: 2017-03-13T12:49:38Z [BEAM-923] Improve DatastoreV1 tests to detect wrong localhost assignment commit 39ff12a24c2f03648f381aa4916efad7417f137b Author: Ismaël Mejía Date: 2017-03-13T12:58:50Z [BEAM-923] Refactor DatastoreV1 Mutate to fix the issue with localhost assignment ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---