Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Thu, 16 Mar 2017 00:03:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13056481.1489621021000.32597.1489622621653@Atlassian.JIRA>
In-Reply-To: <JIRA.13056481.1489621021000@Atlassian.JIRA>
References: <JIRA.13056481.1489621021000@Atlassian.JIRA> <JIRA.13056481.1489621021518@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-1732) Window.Assign does not properly
 populate DisplayData of the enclosing Window transform
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 16 Mar 2017 00:03:48 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927223#comment-15927223 ] 

ASF GitHub Bot commented on BEAM-1732:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2258

    [BEAM-1732] Populate Display Data in Window.Assign

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This populates the diff between the input and output Windowing
    Strategies as the display data of the primitive.
    
    Certain elements are slightly changed, due to implementation details of
    Windowing Strategy. All specified elements, regardless of where they
    were specified, will be included in the Display Data.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam window_assign_display_data

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2258
    
----
commit fc59cd00dfab866bacd4fb12ddb8e8d5e27f6154
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-15T23:52:48Z

    Populate Display Data in Window.Assign
    
    This populates the diff between the input and output Windowing
    Strategies as the display data of the primitive.
    
    Certain elements are slightly changed, due to implementation details of
    Windowing Strategy. All specified elements, regardless of where they
    were specified, will be included in the Display Data.

----


> Window.Assign does not properly populate DisplayData of the enclosing Window transform
> --------------------------------------------------------------------------------------
>
>                 Key: BEAM-1732
>                 URL: https://issues.apache.org/jira/browse/BEAM-1732
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> This should populate the same display data as the enclosing Window.Bound


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)