Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5D7E3200C3B for ; Sat, 18 Mar 2017 14:17:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 57C80160B7F; Sat, 18 Mar 2017 13:17:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A045F160B71 for ; Sat, 18 Mar 2017 14:17:49 +0100 (CET) Received: (qmail 54877 invoked by uid 500); 18 Mar 2017 13:17:48 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 54868 invoked by uid 99); 18 Mar 2017 13:17:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Mar 2017 13:17:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6C7EAC04A1 for ; Sat, 18 Mar 2017 13:17:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9Vft9K0JTLi1 for ; Sat, 18 Mar 2017 13:17:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9DCB360DC0 for ; Sat, 18 Mar 2017 13:17:47 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 430F6E060F for ; Sat, 18 Mar 2017 13:17:43 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 31874254B8 for ; Sat, 18 Mar 2017 13:17:42 +0000 (UTC) Date: Sat, 18 Mar 2017 13:17:42 +0000 (UTC) From: "Tobias Feldhaus (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1718) Returning Duration.millis(Long.MAX_VALUE) in DoFn.getAllowedTimestampSkew() causes Overflow/Underflow MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 18 Mar 2017 13:17:50 -0000 [ https://issues.apache.org/jira/browse/BEAM-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931216#comment-15931216 ] Tobias Feldhaus commented on BEAM-1718: --------------------------------------- When batch-processing, shifting back in time is normal and crucial for me (especially when windowing elements to get them into the right partition in BigQuery). When this method gets deprecated, how should such cases be handled in the future then? > Returning Duration.millis(Long.MAX_VALUE) in DoFn.getAllowedTimestampSkew() causes Overflow/Underflow > ----------------------------------------------------------------------------------------------------- > > Key: BEAM-1718 > URL: https://issues.apache.org/jira/browse/BEAM-1718 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Affects Versions: 0.5.0 > Reporter: Tobias Feldhaus > Assignee: Thomas Groh > > Overriding getAllowedTimestampSkew() in DoFn and returning Duration.millis(Long.MAX_VALUE) (as suggested in the JavaDoc for allowing infinite skew) causes an Overflow/Underflow -- This message was sent by Atlassian JIRA (v6.3.15#6346)