Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 39019200C38 for ; Wed, 1 Mar 2017 03:28:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 37A94160B7C; Wed, 1 Mar 2017 02:28:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 82EA5160B81 for ; Wed, 1 Mar 2017 03:28:51 +0100 (CET) Received: (qmail 88966 invoked by uid 500); 1 Mar 2017 02:28:50 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 88957 invoked by uid 99); 1 Mar 2017 02:28:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 02:28:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 31DCE1A7A8B for ; Wed, 1 Mar 2017 02:28:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.347 X-Spam-Level: X-Spam-Status: No, score=-2.347 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AFakZ7NYcPUx for ; Wed, 1 Mar 2017 02:28:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4782761595 for ; Wed, 1 Mar 2017 02:28:49 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A87CCE0600 for ; Wed, 1 Mar 2017 02:28:47 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8B39124180 for ; Wed, 1 Mar 2017 02:28:46 +0000 (UTC) Date: Wed, 1 Mar 2017 02:28:46 +0000 (UTC) From: "Eugene Kirpichov (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (BEAM-1578) Runners should put PT overrides into a list rather than map MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 01 Mar 2017 02:28:52 -0000 Eugene Kirpichov created BEAM-1578: -------------------------------------- Summary: Runners should put PT overrides into a list rather than map Key: BEAM-1578 URL: https://issues.apache.org/jira/browse/BEAM-1578 Project: Beam Issue Type: Bug Components: runner-dataflow, runner-direct Reporter: Eugene Kirpichov Assignee: Eugene Kirpichov Priority: Minor It was not clear to me from the code that order of overrides is important. Map is not the best data structure for this, especially since no key lookups happen. Referring to https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java and https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java and possibly others. -- This message was sent by Atlassian JIRA (v6.3.15#6346)