Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7234B200C4D for ; Wed, 1 Mar 2017 05:11:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 70F24160B7C; Wed, 1 Mar 2017 04:11:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BC4B4160B7E for ; Wed, 1 Mar 2017 05:11:51 +0100 (CET) Received: (qmail 26180 invoked by uid 500); 1 Mar 2017 04:11:51 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 26145 invoked by uid 99); 1 Mar 2017 04:11:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 04:11:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8AB37C0519 for ; Wed, 1 Mar 2017 04:11:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id C-1WJeaARw4r for ; Wed, 1 Mar 2017 04:11:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4D5205FBC0 for ; Wed, 1 Mar 2017 04:11:49 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 13D1FE053A for ; Wed, 1 Mar 2017 04:11:47 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1E91F24158 for ; Wed, 1 Mar 2017 04:11:46 +0000 (UTC) Date: Wed, 1 Mar 2017 04:11:46 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1353) Beam should comply with PTransform style guide MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 01 Mar 2017 04:11:52 -0000 [ https://issues.apache.org/jira/browse/BEAM-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889464#comment-15889464 ] ASF GitHub Bot commented on BEAM-1353: -------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/beam/pull/1943 > Beam should comply with PTransform style guide > ---------------------------------------------- > > Key: BEAM-1353 > URL: https://issues.apache.org/jira/browse/BEAM-1353 > Project: Beam > Issue Type: Task > Components: sdk-java-core, sdk-java-extensions, sdk-java-gcp, sdk-py > Reporter: Eugene Kirpichov > Assignee: Eugene Kirpichov > Labels: backward-incompatible > > https://beam.apache.org/contribute/ptransform-style-guide/ is a collection of best practices for developing PTransform's. > Some of these practices shaped up relatively recently, and some Beam transforms violate them, introducing inconsistency into Beam APIs and tempting new library writers and users into mimicking code that's best not mimicked. > This is an umbrella bug for cleanups bringing individual Beam transforms in accordance with the style guide. > Please file 1 bug per transform that needs to be fixed (e.g. "Bring KafkaIO in accordance with style guide"); in the bug, describe which aspects need to be fixed (e.g. "should use AutoValue; should explicitly specify type parameters; should not use Coders for serialization") and link it with the current bug. -- This message was sent by Atlassian JIRA (v6.3.15#6346)