Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A4B8D200C31 for ; Wed, 8 Mar 2017 16:36:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A36EF160B83; Wed, 8 Mar 2017 15:36:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ECF4B160B75 for ; Wed, 8 Mar 2017 16:36:41 +0100 (CET) Received: (qmail 86186 invoked by uid 500); 8 Mar 2017 15:36:41 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 86177 invoked by uid 99); 8 Mar 2017 15:36:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2017 15:36:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B8F7CC1D3C for ; Wed, 8 Mar 2017 15:36:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id lJqTb2QUSiwo for ; Wed, 8 Mar 2017 15:36:40 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CD3265FC00 for ; Wed, 8 Mar 2017 15:36:39 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3D25EE0041 for ; Wed, 8 Mar 2017 15:36:38 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id EC83624357 for ; Wed, 8 Mar 2017 15:36:37 +0000 (UTC) Date: Wed, 8 Mar 2017 15:36:37 +0000 (UTC) From: "Aviem Zur (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (BEAM-1336) A StateSpec that doesn't care about the key shouldn't be forced to declare it as type Object MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 08 Mar 2017 15:36:42 -0000 [ https://issues.apache.org/jira/browse/BEAM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aviem Zur reassigned BEAM-1336: ------------------------------- Assignee: Aviem Zur > A StateSpec that doesn't care about the key shouldn't be forced to declare it as type Object > -------------------------------------------------------------------------------------------- > > Key: BEAM-1336 > URL: https://issues.apache.org/jira/browse/BEAM-1336 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Kenneth Knowles > Assignee: Aviem Zur > Priority: Minor > Labels: starter > > In the state API as it exists today, if (as is almost often the case) you are writing a {{StateSpec}} other than a {{KeyedCombiningState}} the key type is irrelevant and the user just has to write {{Object}} there. This was carried over from {{StateTag}} and is an artifact of the visitor pattern there and the difficulty of getting all the types to line up. > I think simplifying the visitor pattern to be more of just a syntax traversal might alleviate the issue and allow us to drop this noise from the syntax. -- This message was sent by Atlassian JIRA (v6.3.15#6346)