Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 96F86200C55 for ; Wed, 8 Mar 2017 16:37:43 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 95C22160B83; Wed, 8 Mar 2017 15:37:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EA533160B86 for ; Wed, 8 Mar 2017 16:37:42 +0100 (CET) Received: (qmail 87385 invoked by uid 500); 8 Mar 2017 15:37:42 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 87373 invoked by uid 99); 8 Mar 2017 15:37:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2017 15:37:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C264CC19F2 for ; Wed, 8 Mar 2017 15:37:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id I6Ytl_uwatx4 for ; Wed, 8 Mar 2017 15:37:41 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E5625618AC for ; Wed, 8 Mar 2017 15:37:40 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 713BEE0AF9 for ; Wed, 8 Mar 2017 15:37:39 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3737F2436D for ; Wed, 8 Mar 2017 15:37:38 +0000 (UTC) Date: Wed, 8 Mar 2017 15:37:38 +0000 (UTC) From: "Aviem Zur (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (BEAM-1276) StateSpecs.combiningValue interface is very awkward to use MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 08 Mar 2017 15:37:43 -0000 [ https://issues.apache.org/jira/browse/BEAM-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aviem Zur reassigned BEAM-1276: ------------------------------- Assignee: Aviem Zur (was: Kenneth Knowles) > StateSpecs.combiningValue interface is very awkward to use > ---------------------------------------------------------- > > Key: BEAM-1276 > URL: https://issues.apache.org/jira/browse/BEAM-1276 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Daniel Mills > Assignee: Aviem Zur > Priority: Minor > > Using StateSpecs.combiningValue with built in combiners is very verbose. For example, to keep a running sum of ints: > {code} > @StateId("count") > private final StateSpec> countSpec = > StateSpecs.combiningValue( > Sum.ofIntegers().getAccumulatorCoder(pipeline.getCoderRegistry(), VarIntCoder.of()), Sum.ofIntegers()); > {code} > This involves getting a reference to the pipeline into the DoFn, guessing/finding the proper type parameters for Sum.ofIntegers(), and manually pulling the accumulator coder out. > For combiners like Sum.ofIntegers() that have a fixed accumulator, the combiningValue call should be able to deduce that. Additionally, it would be nice to remove the type of the accumulator from the StateSpec object, since the user only needs the input and output types in their code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)