Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1383C200C40 for ; Thu, 23 Mar 2017 16:55:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 11F59160B75; Thu, 23 Mar 2017 15:55:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 57401160B6F for ; Thu, 23 Mar 2017 16:55:48 +0100 (CET) Received: (qmail 99194 invoked by uid 500); 23 Mar 2017 15:55:47 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 99185 invoked by uid 99); 23 Mar 2017 15:55:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Mar 2017 15:55:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2DFB618056F for ; Thu, 23 Mar 2017 15:55:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.549 X-Spam-Level: X-Spam-Status: No, score=-98.549 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id nUK9fBcyWcr0 for ; Thu, 23 Mar 2017 15:55:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0182F5FAD1 for ; Thu, 23 Mar 2017 15:55:46 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 13598E0059 for ; Thu, 23 Mar 2017 15:55:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B9CDA21D99 for ; Thu, 23 Mar 2017 15:55:41 +0000 (UTC) Date: Thu, 23 Mar 2017 15:55:41 +0000 (UTC) From: "Thomas Groh (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-576) ReduceFnRunner should GC based on current WM, not on a fired Timer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 23 Mar 2017 15:55:49 -0000 [ https://issues.apache.org/jira/browse/BEAM-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938618#comment-15938618 ] Thomas Groh commented on BEAM-576: ---------------------------------- Yes. Additionally, if we don't set a GC timer we won't promptly expire a window that is expired and flush any remaining output. > ReduceFnRunner should GC based on current WM, not on a fired Timer > ------------------------------------------------------------------ > > Key: BEAM-576 > URL: https://issues.apache.org/jira/browse/BEAM-576 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Thomas Groh > Priority: Minor > > ReduceFnRunner currently uses the time of a timer to determine if it is the garbage collection timer. Instead, it should examine the time a window is expired and the current input watermark to determine if the window should be Garbage Collected. It should additionally ignore all timers for windows that have already been expired. -- This message was sent by Atlassian JIRA (v6.3.15#6346)