beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertwb <...@git.apache.org>
Subject [GitHub] beam pull request #2388: Change side inputs to be references rather than ful...
Date Fri, 31 Mar 2017 01:17:34 GMT
GitHub user robertwb opened a pull request:

    https://github.com/apache/beam/pull/2388

    Change side inputs to be references rather than full PValues.

    This is more consistent with the Runner API's structure.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam side-inputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2388
    
----
commit 85c60920325b8c06f0120fa8be2a2020d4cbdff4
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-03-30T15:20:21Z

    Change side inputs to be references rather than full PValues.
    
    This is more consistent with the Runner API's structure.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message