beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2368: [BEAM-1835] Make Pubsub ackBatch safer
Date Thu, 30 Mar 2017 02:28:19 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2368

    [BEAM-1835] Make Pubsub ackBatch safer

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Checkpoints can be finalized at any point, including while the reader is
    being closed or after it has been. When ackBatch is called and the
    reader is closed, it should return. When close is called while a
    different thread is using the client, it should wait for that thread to
    complete before closing the reader.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam pubsub_npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2368
    
----
commit f00c850599ec864e5e1f2faea0d02b47d89a2aba
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-30T02:26:06Z

    Make Pubsub ackBatch safer
    
    Checkpoints can be finalized at any point, including while the reader is
    being closed or after it has been. When ackBatch is called and the
    reader is closed, it should return. When close is called while a
    different thread is using the client, it should wait for that thread to
    complete before closing the reader.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message