beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <>
Subject [GitHub] beam pull request #2363: [BEAM-1418] MapElements and FlatMapElements should ...
Date Wed, 29 Mar 2017 21:00:51 GMT
GitHub user jkff opened a pull request:

    [BEAM-1418] MapElements and FlatMapElements should comply with PTransform style guide

    For both of these classes, we change (Flat)MapElements.via(fn).withOutputType(td) to (Flat)MapElements.into(td).via(fn),
which is both shorter and allows getting rid of the ugly intermediate and publicly-visible
class MissingOutputTypeDescriptor.
    R: @bjchambers 

You can merge this pull request into a Git repository by running:

    $ git pull map-style

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2363
commit c52cddfaf15eb1d5df65bdcbdfb4ee6f167fe0f2
Author: Eugene Kirpichov <>
Date:   2017-03-29T20:42:29Z

    Removes MapElements.MissingOutputTypeDescriptor
    This comes from changing MapElements.via(fn).withOutputType(td)
    to MapElements.into(td).via(fn) which is also shorter.

commit 6ae80473f9924fe43c18e02f4a139f6421306c7f
Author: Eugene Kirpichov <>
Date:   2017-03-29T20:56:00Z

    Removes FlatMapElements.MissingOutputTypeDescriptor
    This comes from changing FlatMapElements.via(fn).withOutputType(td)
    to FlatMapElements.into(td).via(fn) which is also shorter.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message